run rustfmt on bootstrap folder #37210
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| only as a target\n\n", target), | ||
| None => { | ||
| panic!("\n\ntarget `{}` is not configured as a host, | ||
| \ |
There was a problem hiding this comment.
This is very interesting @nrc.
There was a problem hiding this comment.
This looks like a bug. Could you fix it up manually please?
| @@ -59,7 +59,7 @@ pub fn linkcheck(build: &Build, stage: u32, host: &str) { | |||
| println!("Linkcheck stage{} ({})", stage, host); | |||
| let compiler = Compiler::new(stage, host); | |||
| build.run(build.tool_cmd(&compiler, "linkchecker") | |||
| .arg(build.out.join(host).join("doc"))); | |||
| .arg(build.out.join(host).join("doc"))); | |||
There was a problem hiding this comment.
I'm a little worried about formatting like this being a little confusing to read, e.g. it's hard to see if arg is changed on tool_cmd or run here.
There was a problem hiding this comment.
Fair point. Lets see @nrc says
There was a problem hiding this comment.
This is the downside of using block indent rather than visual indent for method/field chains (cc rust-lang/style-team#8). Unfortunately, visual indent is a nightmare where there are closures nested within, and I don't think there is any way to combine the two.
| println!("Check compiletest {} ({} -> {})", | ||
| suite, | ||
| compiler.host, | ||
| target); |
There was a problem hiding this comment.
What's going on here? The signature was extended but the println was wrapped?
There was a problem hiding this comment.
There's a heuristic for breaking function calls (and macro uses) before they fill the whole line.
|
☔ The latest upstream changes (presumably #37269) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @nrc |
|
☔ The latest upstream changes (presumably #37597) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r = me with a rebase and the manual fixup described in a comment |
|
Closing due to inactivity. @srinivasreddy If you're still interested in these changes, let me know and I can reopen, otherwise you could just open a new PR. |
No description provided.